Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with not translated dialog #280

Merged
merged 3 commits into from
Jul 22, 2020
Merged

fix issue with not translated dialog #280

merged 3 commits into from
Jul 22, 2020

Conversation

nadar
Copy link
Contributor

@nadar nadar commented Jul 22, 2020

When a page has not been translated the "translate now" where not showing. The new implementation use the correct response status with NotFoundHttpExceptions instead of an "error" variable.

@codeclimate
Copy link

codeclimate bot commented Jul 22, 2020

Code Climate has analyzed commit 67c16b9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.4% (0.0% change).

View more on Code Climate.

@nadar nadar merged commit bf5d496 into master Jul 22, 2020
@nadar nadar deleted the not-found-element branch July 22, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant