-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acuity support #614
Acuity support #614
Conversation
c2fbdd5
to
a80ba14
Compare
deafe0a
to
dee687a
Compare
Hi Lutz, Is there anything need to be modified ? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There are multiple similar formats for deep learning models already. Can Acuity use an existing format instead of creating another duplicate format?
jsyaml
should not be checked in as obfuscated code. For JSON, Protocol Buffers and FlatBuffers there are custom implementation usingbase.TextDecoder
. A similar approach should be followed for YAML.- Using JSON and YAML and Pickle (3 different standards) for a single model is a fragile design. Ideally there should be no YAML dependency.
test/models.json
Outdated
{ | ||
"type": "acuity", | ||
"target": "inception_v1.json", | ||
"source": "https://raw.githubusercontent.com/VeriSilicon/acuity-models/master/models/inception_v1/inception_v1.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is sorted alphabetically by type
. This is only testing the JSON code, not the YAML and binary readers. Please add a more comprehensive sample.
Thanks!
|
c78330b
to
b2f9ff2
Compare
It will only get more difficult over time. This is an overcomplicated design with lots of moving parts. Better to fix it early on while you still can. Ideally you should consider what value the framework actually provides and if it does need yet another new file format or can just use an existing one. |
24cfc6e
to
d72ba77
Compare
59e7f16
to
ad04a3a
Compare
Thanks for your suggestions. I will remove the code of loading .quantize and .data, let netron just handle the model structure. |
acf818a
to
404b5f4
Compare
64dd724
to
f11c219
Compare
Signed-off-by: Jiang Best <[email protected]>
Why is this format needed? There are a dozen other deep learning formats that are more or less identical. |
Thanks! When we started the project at 2016, there weren't suitable formats for us. so ... |
Hi,
This patch enables the support of Acuity models, please help to review the patch, any suggestions are welcome.
Acuity is an AI framework that can convert the models of other framework(such as tensorflow, tflite, caffe, onnx, etc) to Acuity models, then generate high performance code for embedded platforms.
.json
file is the Acuity model file which contains the model structure, and.data
file will be loaded for weights and biases,.quantize
file is for quanzation parameters. the output tensors' shape of each layer will be inferred if the input shape(s) are provied in model files.Some popular models converted by Acuity can be found here: https://verisilicon.github.io/acuity-models/
Thanks.
#657