Update default.json with vimFx-profile #98
Conversation
added VimFx-profile didn't set keys for paste & go/activate clipboard functionality, as it doesn't work in my version of FF.
|
Noticed, I missed adding some functionality, I've never used in VimFx, adding that now, so don't pull yet |
|
Can't figure it out. When I mark the String "maybe " and then press the assigned button for "activate clipboard in tab, it changes and follows the url to "https://www.google.de/webhp?gws_rd=cr&dcr=0&ei=txv_WaLyFIjNkwXr9I-wBg", which is a blank google page for me. Expected behaviour (for a VimFx user, at least) would be, that it pastes "maybe " into the address bar and then presses enter, to make a normal search, with whatever search engine or go to the site, if the String is an URL. So I wont add that, as it doesn't do what a VimFx user would expect and/or is broken. Profile is as VimFx-like as it's gonna get, with the current feature set, so please pull. |
src/options/Keybindings/default.json
Outdated
| "focusInput": [ | ||
| [{ "code": "KeyE", "key": "e" }, { "code": "KeyF", "key": "f" }] | ||
| ], | ||
| "hintChars": "sadfjklewcmpgh", |
There was a problem hiding this comment.
The default VimFx hint chars are: fjdkslaghrueiwoncmv
src/options/Keybindings/default.json
Outdated
| "downloadLink": [], | ||
| "focusLink": [], | ||
| "focusInput": [ | ||
| [{ "code": "KeyE", "key": "e" }, { "code": "KeyF", "key": "f" }] |
There was a problem hiding this comment.
ef should be assigned to focusLink, not focusInput, since ef focuses both links and inputs in VimFx (really, anything that is focusable), and focusLink does just that.
src/options/Keybindings/default.json
Outdated
| "scrollToTop": [ | ||
| [{ "code": "KeyG", "key": "g" }, { "code": "KeyG", "key": "g" }] | ||
| ], | ||
| "scrollToLeft": [], |
There was a problem hiding this comment.
If this works the same as VimFx's scroll_to_left command, the default VimFx shortcuts are 0 and ^.
src/options/Keybindings/default.json
Outdated
| [{ "code": "KeyG", "key": "g" }, { "code": "KeyG", "key": "g" }] | ||
| ], | ||
| "scrollToLeft": [], | ||
| "scrollToRight": [], |
There was a problem hiding this comment.
If this works the same as VimFx's scroll_to_right command, the default VimFx shortcut is $.
src/options/Keybindings/default.json
Outdated
| "scrollToRight": [], | ||
| "goBack": [[{ "code": "KeyH", "key": "H", "shiftKey": true }]], | ||
| "goForward": [[{ "code": "KeyL", "key": "L", "shiftKey": true }]], | ||
| "nextPage": [], |
There was a problem hiding this comment.
What shortcut in Saka Key is this? It sounds a lot like VimFx's follow_next command, but as far as I know Saka Key doesn't have such a command. Confusing. Anyway, the default shortcuts for clicking next/previous links in VimFx are [/].
There was a problem hiding this comment.
This would be "Go backward/forward in history", which is H/L in VimFx. I don't now what "follow_next" does in VimFx, actually. If it's not in Saka Key, I can't add it anyway.
src/options/Keybindings/default.json
Outdated
| "passOneKey": [[{ "code": "KeyI", "key":"I", "shiftKey": true }]], | ||
| "passAllKeys": [{ "code": "KeyI", "key":"i"}], | ||
| "exitPassMode": [], | ||
| "exitPassMode": [[{ "code": "Escape", "key":"Esc"}]], |
There was a problem hiding this comment.
You seem to have specified exitPassMode twice here.
There was a problem hiding this comment.
yup, missed that
|
@davidermined There's nothing to approve. If you agree with the changes, all you need to do is update the PR. GitHub will collapse comments made on lines of code if they change, signalling that the comment has been addressed. |
|
Thanks for the contribution. There were a few bugs I had to fix. Please add this version of default.json to your PR. You can do a diff to see the 3 or so lines that changed. Also, building Saka Key works on Windows. I gave my Windows VM a spin just to confirm. I followed these instructions. |
for three missed outer brackets and an accidentally deleted character
|
Thanks! |
didn't set keys for paste & go/activate clipboard functionality, as it doesn't seem work in my version of FF.