feat: persisting microchain server data #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of bloating the server's RAM with data from potentially many microchains, persist the data on the file system. This allows servers to not lose data on temporary shutdowns.
arthurpaulino
force-pushed
the
ap/microchain-persisting-server
branch
from
fd96b82 to
510cecd
Compare
wwared
approved these changes
Nov 6, 2024
|
|
||
| fn dump_state(id: &[F], state: &ChainState) -> Result<()> { | ||
| dump_microchain_data(id, "state", state) | ||
| } |
There was a problem hiding this comment.
nit: Renaming the functions to save_ instead of dump_ might be nicer (i.e. it's the counterparty to load_, and makes it clear it overwrites the on-disk state) (but it's a matter of opinion, I don't mind leaving it as-is)
There was a problem hiding this comment.
I'm reusing the terminology from other places in the repo (e.g. dump-expr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of bloating the server's RAM with data from potentially many microchains, persist the data on the file system. This allows servers to not lose data on temporary shutdowns.