-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new expanded configuration #5
Conversation
purpose is for selective import
ensuring test files don't commit
Purpose: - used to read the config file and validate its contents New config file fields: ⚙️ helpers: accepts array of function names as well as true or false ⚙️custom_helper_folder: place to find helper functions ⚙️rules_version: accepts both strings and numbers ⚙️rules_folder: where to find the rules ⚙️rules_output: where to output the final file ⚙️use_firebase_config: to get output file name from firebase.json Validation established for each config field with appropriate logging
Hey @Bullfrog1234 Wow - thanks a lot for this PR - appreciate it! Seems to add a lot of new functionality! You'll hear from me, Thanks again |
Hey @lupas No problem, hope it is all up to your standard I found this library and started using it to build rules in 4 of my projects, I made the changes for those projects, but in the end I decided to share back with you to hopeful provide benefits to others Cheers, |
Hey @Bullfrog1234 Finally had time to look at the PR and gotta say - this is some awesome work! I tested it and fixed a small thing, but in general this looks great to me. Already published it as v1.0.0. Thanks again a lot - appreciate it. Best regards & Merry Christmas! |
This pull request makes the following changes:
yup
) with some parts falling back to defaults if requiredchalk
for formatting, including alerts on anytime it is falling back to defaultsThe full config is now:
["authUserEmail", "authUserEmailIsVerified", "authUserUid", "existingData", "hasAmtOfWriteFields", "incomingData", "isAuthenticated"]
true
to include all helper functions orfalse
to include non of the helper functions or an array of the function namesnull
null
| string"1"
"1" | "2" | 1 | 2
"rules"
"firestore.rules"
false
firebase.json
to get the rules output file name and locationThis is the first time I have contributed to a library so please tell me if there is something I sould have done.