Make nodeport optional

In some use cases, users of kafdrop may opt for clusterIP or other K8s Service Types. This help avoid errors from helm when installing the service. Such error may be expressed as: ``` Forbidden: ... may not be used when `type` is 'ClusterIP' ``` Ref: 1. kubernetes/kubectl#221 2. Similar issue: helm/charts#16940 Signed-off-by: Luong Vo <[email protected]>
luong-komorebi · Jan 30, 2020 · 461567b · 461567b
1 parent 70d2c08
commit 461567b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/chart/templates/service.yaml b/chart/templates/service.yaml
@@ -14,7 +14,9 @@ spec:
       targetPort: http
       protocol: TCP
       name: http
-      nodePort: {{ .Values.service.nodePort }}
+{{ if (and (eq .Values.service.type "NodePort") (not (empty .Values.service.nodePort))) }}
+      nodePort: {{.Values.service.nodePort}}
+{{ end }}
   selector:
     app.kubernetes.io/name: {{ include "chart.name" . }}
     app.kubernetes.io/instance: {{ .Release.Name }}