Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement notification API #522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement notification API #522

wants to merge 2 commits into from

Conversation

sphilee
Copy link
Contributor

@sphilee sphilee commented Nov 12, 2017 •
edited
Loading

Implement notification API

showNotification function : Functions to create and show notifications

processClickEvent function : The function that connects to url when the notification is clicked

ISSUE=none

@sphilee sphilee requested a review from romandev as a code owner November 12, 2017 08:39
yjaeseok
yjaeseok reviewed Nov 12, 2017
View reviewed changes
Copy link
Collaborator

@yjaeseok yjaeseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write pull request description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjaeseok yjaeseok yjaeseok left review comments

@romandev romandev Awaiting requested review from romandev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sphilee @yjaeseok