Fix panic for case when no metrics are returned #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #30 |
JacobValdemar
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Thank you very much for this generous contribution @lwalter! Everything looks good, so I am merging it and creating a new release 🚀
|
@lwalter can I get you to sign your commits? The base branch requires all commits to be signed. Learn more about signing commits. |
Remove extra whitespace
Depending on the configured query and particular timespan, it is possible for no metrics to be returned. Which in the previous implementation would cause a panic. This commit gracefully handles the scenario by continuing to the next query job in this particular case.
|
@JacobValdemar Apologies, I have signed and re-pushed the commits to this branch. I can see that they are "Verified". Once this branch is merged will a new release branch be created automatically by the build pipeline? If not, how can I get one created? Thanks! |
|
@lwalter Thanks! I will make sure to create a new release and publish the images 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thank you for creating this project, it's been helpful for monitoring our Humio clusters. However I did notice a panic for cases where some more complex queries might not have a metric for a particular timespan. In this case the exporter would panic when trying access the Events array at element 0.
I've introduced a fix which will simply continue for this particular case and have verified it in my own environment.
Please let me know if I can assist with getting this merged ASAP.
Much appreciated!