Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number field setter #1970

Open
wants to merge 4 commits into
base: 1.x
Choose a base branch
from
Open

Fix number field setter #1970

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05d76c6
Fix number field setter
ken717w Sep 26, 2024
e94c4f4
Simplify the string to number casting
ken717w Sep 30, 2024
3b1b6af
Update Number.php
alecritson Sep 30, 2024
1d965f2
Merge branch '1.x' into bugfix/number-field-casting
glennjacobs Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/FieldTypes/Number.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function setValue($value)
throw new FieldTypeException(self::class.' value must be numeric.');
}

$this->value = $value;
$this->value = $value ? $value + 0 : '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does returning '' solve the initial issue?

will setting type hint to property/return/argument solve the issue?

}

/**
Expand Down