Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: fix lfs, stevedonovan and orbit broken links #478

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jlaurens
Copy link
Contributor

@jlaurens jlaurens commented Jun 3, 2024

This is not ready to merge.

Some links were broken and have been fixed in files of the repo.

I could not build the documentation by myself with ldoc (error: unknown file attribute: b)
and I could not find a way to make ldoc replace "lsf.dir" in file

docs_topics/04-paths.md

by

<a href="https://lunarmodules.github.io/luafilesystem/manual.html#dir">lfs.dir</a>

in file

docs/manual/04-paths.md.html

instead of

<a href="http://stevedonovan.github.io/lua-stdlibs/lfs.html#dir">lfs.dir</a>

which is the broken link

@alerque alerque marked this pull request as draft June 3, 2024 08:41
@Tieske Tieske marked this pull request as ready for review June 4, 2024 09:49
@Tieske
Copy link
Member

Tieske commented Jun 4, 2024

@jlaurens I fixed the isues. And pushed the changes on your branch. I lost the attribution to you in the process.

Can you rebase and recommit to fix the attribution? then this is good to go I think.

@alerque

This comment was marked as outdated.

@jlaurens
Copy link
Contributor Author

jlaurens commented Jun 4, 2024

rebased

@Tieske Tieske merged commit a26ca8d into lunarmodules:master Jun 5, 2024
8 checks passed
@jlaurens jlaurens deleted the broken-links branch June 5, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants