Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) also run examples in CI #351

Closed
wants to merge 1 commit into from
Closed

chore(ci) also run examples in CI #351

wants to merge 1 commit into from

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Sep 27, 2020

No description provided.

@alerque
Copy link
Member

alerque commented Sep 27, 2020

Please don't, see my comment here.

I deliberately ran it in two steps because then it is clear from the Travis output log what failed. The output isn't very clear when they are both run together. Also it allowed for coverage testing to be separate.

I did consider adding coverage reporting to the examples, but my experience with testing on other projects has led me to believe that its better to measure test coverage via the most specific unit testing possible, big monolithic examples that cover lots of ground can be very useful to end users and making sure they work can catch some kinds of issues but they don't do a great job at identifying specific expectations of each interface along the way. It's surprising what can slip though as 'working overall' but actually be broken inside. I would rather specific unit tests be the baseline for coverage reporting. Examples should work too (hence adding the to the CI run) but that shouldn't count as really testing the expectations on each function.

@Tieske Tieske closed this Sep 27, 2020
@Tieske Tieske deleted the examples-ci branch September 27, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants