Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pylake v0.10.1 #207

Merged
merged 5 commits into from
Oct 27, 2021
Merged

Release Pylake v0.10.1 #207

merged 5 commits into from
Oct 27, 2021

Conversation

JoepVanlier
Copy link
Member

@JoepVanlier JoepVanlier commented Oct 26, 2021

Why this PR?
The time has come to do another Pylake release.

Reason for the release now is to make sure there's a release to tag for specific force calibration improvements.

Some notes:
I have piggybacked a few very small docs fixups and pinning the docutils to <0.18 since we were having issues with the docs failing on RtD. See also readthedocs/readthedocs.org#8616

Note that I have not entered a date in the changelog yet, but I will do so once the PR is approved.

Docs build here: https://lumicks-pylake.readthedocs.io/en/release_pr

new version of `docutils` seems to cause our docs build to fail
@JoepVanlier JoepVanlier requested a review from a team as a code owner October 26, 2021 16:24
@JoepVanlier JoepVanlier requested review from tiagobonetti, agom, rpauszek and facutuesca and removed request for a team October 26, 2021 16:24
changelog.md Outdated
@@ -8,13 +8,15 @@
* Added `KymoLineGroup.fit_binding_times()` to allow for dwelltime analysis of bound states found using kymotracker. See [kymotracking](https://lumicks-pylake.readthedocs.io/en/latest/tutorial/kymotracking.html) for more information.
* Allow using data acquired with a fast force sensor by passing `fast_sensor=True` when creating a `PassiveCalibrationModel`.
* Allow using hydrodynamically correct power spectrum when performing force calibration. See [force calibration](https://lumicks-pylake.readthedocs.io/en/latest/tutorial/force_calibration.html) for more information.
* Add ability to crop `CorrelatedStacks`. See [Correlated stacks](https://lumicks-pylake.readthedocs.io/en/latest/tutorial/correlatedstacks.html#correlated-stacks) for more information.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add ability to crop `CorrelatedStacks`. See [Correlated stacks](https://lumicks-pylake.readthedocs.io/en/latest/tutorial/correlatedstacks.html#correlated-stacks) for more information.
* Added ability to crop `CorrelatedStacks`. See [Correlated stacks](https://lumicks-pylake.readthedocs.io/en/latest/tutorial/correlatedstacks.html#correlated-stacks) for more information.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(also for the axial force detection, the first line)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

changelog.md Outdated

#### Bug fixes

* Show an error message when user attempts to refine lines before tracking or loading them so the kymotracker widget does not become unresponsive.
* Force calibration models now throw an error when a bead diameter of less than `10^-2` microns is used (rather than produce `NaN` results).
* Fixed bug that prevented export of `CorrelatedStack` if the alignment matrices were missing from the metadata.
* Fixed bug where the exported metadata fields were erroneously exported as `"Applied channel X alignment"` for `CorrelatedStack` where the alignment was not actually applied.
* Fix error in optimal point determination for MSD estimator. Note that this bug led to an error being thrown when the number of points in the trace was exactly 4. Now it results in a more informative error message (`You need at least 5 time points to estimate the number of points to include in the fit.`).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix error in optimal point determination for MSD estimator. Note that this bug led to an error being thrown when the number of points in the trace was exactly 4. Now it results in a more informative error message (`You need at least 5 time points to estimate the number of points to include in the fit.`).
* Fixed error in optimal point determination for MSD estimator. Note that this bug led to an error being thrown when the number of points in the trace was exactly 4. Now it results in a more informative error message (`You need at least 5 time points to estimate the number of points to include in the fit.`).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@rpauszek rpauszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoepVanlier JoepVanlier merged commit b5875d1 into main Oct 27, 2021
@JoepVanlier JoepVanlier deleted the release_pr branch October 27, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants