Skip to content

Commit

Permalink
fix: update to classy-solid, lowclass, and add tests to ensure that o…
Browse files Browse the repository at this point in the history
…verriden subclass fields decorated with @element do not lose reactivity

update internals based on classy-solid

BREAKING: update decorator paramter types with types from latest TypeScript instead of our own types. This may require updating your TypeScript version and fixing some spots where decorators are used be parameters are no long type `any`.
  • Loading branch information
trusktr committed Nov 17, 2023
1 parent 47fa136 commit e4d4d79
Show file tree
Hide file tree
Showing 20 changed files with 196 additions and 202 deletions.
2 changes: 0 additions & 2 deletions dist/LumeElement.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ declare class LumeElement extends HTMLElement {
static observedAttributes?: string[] | Record<string, AttributeHandler>;
private __attributesToProps?;
protected _preUpgradeValues: Map<PropertyKey, unknown>;
protected __propsSetAtLeastOnce__?: Set<PropertyKey>;
protected __reactifiedProps__?: Set<PropertyKey>;
protected ___init___: void;
private __handleInitialPropertyValuesIfAny;
protected template?: Template;
Expand Down
2 changes: 1 addition & 1 deletion dist/LumeElement.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions dist/LumeElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/LumeElement.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/LumeElement.test.js.map

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions dist/attribute.d.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { ElementCtor } from './element.js';
export declare const __classFinishers: ((Class: ElementCtor) => void)[];
export declare function attribute(handler?: AttributeHandler): (value: any, context: any) => any;
export declare function attribute(value: any, context: any): any;
type AttributeDecoratorContext = ClassFieldDecoratorContext | ClassGetterDecoratorContext | ClassSetterDecoratorContext;
export declare function attribute(handler?: AttributeHandler): (value: unknown, context: AttributeDecoratorContext) => any;
export declare function attribute(value: unknown, context: AttributeDecoratorContext): any;
export declare namespace attribute {
var string: AttributeType<string>;
var number: AttributeType<number>;
Expand Down
Loading

0 comments on commit e4d4d79

Please sign in to comment.