fix(ColorPicker): unable to set R/G/B components as 0 #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plagoa
requested review from
zettca and
MEsteves22
and removed request for
a team
zettca
approved these changes
Dec 4, 2024
Comment on lines
98
to
100
| r: data.r !== undefined ? data.r : rgb?.r, | ||
| g: data.g !== undefined ? data.g : rgb?.g, | ||
| b: data.b !== undefined ? data.b : rgb?.b, |
There was a problem hiding this comment.
we have syntax for this case
Suggested change
| r: data.r !== undefined ? data.r : rgb?.r, | |
| g: data.g !== undefined ? data.g : rgb?.g, | |
| b: data.b !== undefined ? data.b : rgb?.b, | |
| r: data.r ?? rgb?.r, | |
| g: data.g ?? rgb?.g, | |
| b: data.b ?? rgb?.b, |
plagoa
force-pushed
the
fix/color_picker_rgb
branch
from
45f722b to
9d33712
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
value of 0 was being interpreted as
false