fix(ColorPicker): hue slider goes out of bounds #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plagoa
requested review from
zettca and
francisco-guilherme
and removed request for
a team
zettca
reviewed
Dec 4, 2024
| @@ -54,7 +54,7 @@ export const { staticClasses, useClasses } = createClasses(name, { | |||
| marginLeft: "0px", | |||
| border: "2px solid #fff", | |||
| borderRadius: theme.radii.circle, | |||
| transform: "translate(0, -2px)", | |||
| transform: "translate(-6px, -2px)", | |||
There was a problem hiding this comment.
the visual changes seem unexpected, it goes out of bounds when vertical & on the start of the slider
There was a problem hiding this comment.
Yeah, I fixed it for the vertical case too. Still, some visual changes are expected.
plagoa
force-pushed
the
fix/color_picker_hue_slider
branch
from
1f3822d to
9f448a8
Compare
2 tasks
zettca
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.