New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DropDownMenu): move getPrevNextFocus for perf & ssr support #4441

Merged

zettca merged 1 commit into master from fix/stuffs

Nov 20, 2024

Member

zettca commented Nov 20, 2024 •

edited

Loading

move getPrevNextFocus inside the block where it's needed, for SSR support & performance reasons; as it uses document.querySelectorAll every render
memo classes


          fix(DropDownMenu): move getPrevNextFocus for perf & ssr support

b2f63dc

zettca requested a review from a team as a code owner

November 20, 2024 09:59

zettca requested review from francisco-guilherme and MEsteves22 and removed request for a team

November 20, 2024 09:59

github-actions bot temporarily deployed to uikit/pr-4441

November 20, 2024 10:03

Destroyed

github-actions bot deployed to uikit-docs/pr-4441

November 20, 2024 10:04

View deployment

plagoa approved these changes

View reviewed changes

zettca merged commit 101d28d into master

12 checks passed

zettca deleted the fix/stuffs branch

November 20, 2024 11:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

plagoa plagoa approved these changes

francisco-guilherme Awaiting requested review from francisco-guilherme francisco-guilherme is a code owner automatically assigned from lumada-design/imperial

MEsteves22 Awaiting requested review from MEsteves22 MEsteves22 is a code owner automatically assigned from lumada-design/imperial

Labels

None yet