Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CanvasContext #4439

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: add CanvasContext #4439

merged 1 commit into from
Nov 22, 2024

Conversation

plagoa
Copy link
Contributor

@plagoa plagoa commented Nov 19, 2024

Adds a HvCanvasContext. Canvas components (SidePanel, BottomPanel and CanvasToolbar) use this context to resize automatically when the side panel is resized. If no CanvasContext is used then the components won't resize automatically and it's up to the user to do that if that's needed.

@plagoa plagoa requested a review from a team as a code owner November 19, 2024 10:54
@plagoa plagoa requested review from zettca and MEsteves22 and removed request for a team November 19, 2024 10:54
@github-actions github-actions bot temporarily deployed to uikit/pr-4439 November 19, 2024 10:58 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4439 November 19, 2024 10:59 Destroyed
@plagoa plagoa force-pushed the feat/canvas_context branch 2 times, most recently from dd86921 to 7b5fe70 Compare November 19, 2024 11:12
@github-actions github-actions bot temporarily deployed to uikit/pr-4439 November 19, 2024 11:17 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4439 November 19, 2024 11:17 Destroyed
packages/cli/src/templates/Canvas/index.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Canvas/SidePanel/SidePanel.test.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Canvas/SidePanel/useResizable.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Canvas/Toolbar/Toolbar.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Canvas/SidePanel/SidePanel.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Canvas/SidePanel/SidePanel.tsx Outdated Show resolved Hide resolved
@plagoa plagoa force-pushed the feat/canvas_context branch 2 times, most recently from fa6c1dc to 4a97967 Compare November 19, 2024 11:54
@github-actions github-actions bot temporarily deployed to uikit/pr-4439 November 19, 2024 11:58 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4439 November 19, 2024 11:59 Destroyed
@plagoa plagoa marked this pull request as draft November 19, 2024 17:58
@plagoa plagoa force-pushed the feat/canvas_context branch from 4a97967 to b5e207e Compare November 20, 2024 11:43
@github-actions github-actions bot temporarily deployed to uikit/pr-4439 November 20, 2024 11:48 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4439 November 20, 2024 11:48 Destroyed
@plagoa plagoa marked this pull request as ready for review November 20, 2024 16:06
@plagoa plagoa force-pushed the feat/canvas_context branch from b5e207e to 52571cf Compare November 20, 2024 16:07
@github-actions github-actions bot temporarily deployed to uikit/pr-4439 November 20, 2024 16:12 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4439 November 20, 2024 16:12 Destroyed
@plagoa plagoa force-pushed the feat/canvas_context branch from 52571cf to 6ddd776 Compare November 20, 2024 16:13
@github-actions github-actions bot temporarily deployed to uikit/pr-4439 November 20, 2024 16:18 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4439 November 20, 2024 16:18 Destroyed
packages/pentaho/src/Canvas/SidePanel/SidePanel.test.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Canvas/index.ts Outdated Show resolved Hide resolved
packages/pentaho/src/Canvas/Toolbar/Toolbar.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Canvas/SidePanel/SidePanel.tsx Outdated Show resolved Hide resolved
@plagoa plagoa force-pushed the feat/canvas_context branch from 6ddd776 to 068b2ee Compare November 21, 2024 14:51
@github-actions github-actions bot temporarily deployed to uikit/pr-4439 November 21, 2024 14:56 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4439 November 21, 2024 14:56 Destroyed
@plagoa plagoa force-pushed the feat/canvas_context branch from 068b2ee to 72728db Compare November 22, 2024 14:35
@zettca zettca merged commit 5f85304 into master Nov 22, 2024
12 checks passed
@zettca zettca deleted the feat/canvas_context branch November 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants