feat(utils): add @hitachivantara/uikit-react-utils package
#4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes utils from `shared` (classes) chore: hoist useDefaultProps & mergeStyles
zettca
requested review from
francisco-guilherme and
VGervasio
and removed request for
a team
nantunes
reviewed
Aug 14, 2024
| @@ -0,0 +1,74 @@ | |||
| { | |||
| "name": "@hitachivantara/uikit-react-utils", | |||
| "version": "0.1.0", | |||
There was a problem hiding this comment.
Version bellow 1.0 is intentional? It means consumers should consider the exposed APIs as unstable?
There was a problem hiding this comment.
Yes, at least while we decide what we migrate/include or not in this library.
We can migrate to a major (eg. 5.x) anytime later on
francisco-guilherme
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hitachivantara/uikit-react-utilspackageclassesutilities fromsharedtoutils(that were changed in perf: remove core dependency in viz & code-editor #4255)useDefaultProps,mergeStylesImportant
Refactor is in different commit for ease of review. Please squash when merging
TODO:
decide which othercore/src/utilsutils should be moved to@hitachivantara/uikit-react-utilsclean-up/remove long unused and/or internal core utils being exported?we can address this later 👆