Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

Support "2 Click Install" feature #85

Closed
wants to merge 4 commits into from

Conversation

idolize
Copy link

@idolize idolize commented Sep 7, 2020

Proposed Changes

Support for uploading custom maps without audio files to BeatSaver

  • Add requiresExternalAudioFile boolean to the beatmap metadata
  • Set requiresExternalAudioFile to true if the zip file contains audio.json and fingerprint.bin
  • If requiresExternalAudioFile, determine song length via audio.json instead of ffprobe
  • If requiresExternalAudioFile, disable in-browser preview functionality
  • If requiresExternalAudioFile, show "bring your own song" indicator in stats area

Platforms

This pull request modifies: (select all that apply)

  • Client
  • Server

Types of Changes

This pull request is contains: (select all that apply)

  • Bug fixes (non-breaking change which fixes an issue)
  • New features (non-breaking change which adds functionality)
  • Breaking changes (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the contribution guidelines
  • I have checked the changes adhere to the project's style guide and all tests pass
  • I have (to the best of my ability) checked for vulnerabilities, or any ways that my code could be abused and concluded that it is safe to run in production

Further Comments

This is part of a series of changes aimed at allowing custom maps to be created, uploaded, and used all without distributing any song file directly (instead the user must supply their own song).

luludotdev/beatmap-schemas#10
bsmg/ModAssistant#232

@stale
Copy link

stale bot commented Sep 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 29, 2020
@idolize
Copy link
Author

idolize commented Sep 29, 2020

@lolPants do you have any thoughts about this?

@stale stale bot removed the stale label Sep 29, 2020
@stale
Copy link

stale bot commented Oct 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 20, 2020
@stale stale bot closed this Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant