fix: Allow direct import of all files in dist #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skimaharvey
approved these changes
Jun 3, 2023
CJ42
approved these changes
Jun 5, 2023
richtera
force-pushed
the
patch/export-dist
branch
from
ba656e3 to
61cada0
Compare
richtera
force-pushed
the
patch/export-dist
branch
from
f0fc6c4 to
de3625f
Compare
|
Rebased so that only the single line change shows I PR. I had rebased it to main by mistake |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
Allow direct import of constants.es.js and constants.cjs.js in the dist folder.
This will cause an error in typescript because of constants.d.ts not being found,
but hardhat uses the node loader and is not capable of finding the right file to load.
It uses ts-node which decides to pick the .es.js file, but that has "import" statements
which are not compatible with the nodejs compiler. I.e. it assumes modules
use require/module instead of import/export.