This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
Derrick branch 2 #75
Open
Derrick branch 2 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YashZolmajdi
reviewed
Jan 9, 2019
| </li> | ||
| ))} | ||
| </ul> | ||
| <div> |
There was a problem hiding this comment.
need to correct tab indentation looks like the open and close divs do not match
YashZolmajdi
reviewed
Jan 9, 2019
| @@ -249,6 +250,23 @@ class View extends React.Component { | |||
| /> | |||
| <TypingIndicator typing={typing[room.id]} /> | |||
| <CreateMessageForm state={this.state} actions={this.actions} /> | |||
| { | |||
There was a problem hiding this comment.
same here indentation needs to match the rest of the file. file is using 2 spaces to indent
|
Hey just a heads up. This PR contains commits from a different PR #74. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 -> added live geolocation tacked below the send message - but I think there needs to be a property to attach location to for each message? I'm not sure chatkit has this