Correctly handle generic model name resolution #427
Conversation
|
|
||
| const resolvedName = genericTypes.reduce((acc, generic) => { | ||
| if (ts.isTypeReferenceNode(generic) && generic.typeArguments && generic.typeArguments.length > 0) { | ||
| return [...acc, this.getTypeName(generic.typeName.getText(), generic.typeArguments)]; |
There was a problem hiding this comment.
@WoH I mentioned this in another recent PR, but there's a performance hit for using the spread operator since you are iterating through the acc array on every loop of the reduce. The implementation of the reduce could still be a pure function if it mutates the seed since the seed is not considered to be part of the inputs. In fact, it's much more standard in what I've seen to just use acc.push. Now I'm aware that genericTypes probably has a very small length, so the performance advantages are probably minimal, but I also think that .push is more readable. Here's the JSPerf from last time to demonstrate the performance advantages: https://jsperf.com/reduce-with-new-set-vs-seed
There was a problem hiding this comment.
#399