Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable eslint along with tslint in templates #368

Merged
merged 1 commit into from
Aug 13, 2019
Merged

fix: disable eslint along with tslint in templates #368

merged 1 commit into from
Aug 13, 2019

Conversation

scttcper
Copy link
Contributor

@scttcper scttcper commented Jul 10, 2019

some are using eslint instead of tslint, there shouldn't be any negative side effects of disabling both in the default templates

@endor
Copy link
Collaborator

endor commented Aug 7, 2019

Hm, I can't really follow why this makes sense. This project uses tslint, so it makes sense to explicitly disable that for the templates. If you use tsoa within your project, it's a dependency, and you probably don't want to lint your dependencies, right?

@dgreene1
Copy link
Collaborator

dgreene1 commented Aug 7, 2019

@endor I think it’s because routes.ts lives within the consumers own repo so it does get linted. I could see why this would be a problem for people. I’d nominate to approve this PR, but I’ll allow @endor to respond first.

@scttcper, you’re okay with using eslint’s ignore / glob options in the meantime right?

@endor
Copy link
Collaborator

endor commented Aug 7, 2019

Okay, that's a fair point. But I'm still not sure whether it wouldn't be better to tell the linter to just ignore the routes.ts file, since it's generated.

@scttcper
Copy link
Contributor Author

scttcper commented Aug 7, 2019

@endor @dgreene1 When moving people at our company from tslint to eslint we were looking for lowest friction. Routes.ts would be the only thing we need to ignore and tslint was already ignoring it.

Totally fine using .eslintignore file

@dgreene1
Copy link
Collaborator

Since tslint has officially been deprecated in favor of eslint, I think it makes a lot of sense to accept this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants