Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(specGenerator)/remove request-prop param #1701

Merged

Conversation

chappelo
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues
closes #1663

adjusted spec generators to match in params (removed request-prop)

https://github.com/OAI/OpenAPI-Specification/blob/main/versions/2.0.md
https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.0.md

Test plan

added test cases for both SpecGenerator2 and SpecGenerator3 to ensure request-props aren't added to the spec.

@jackey8616
Copy link
Collaborator

@chappelo
Can you provide a positive test cases covers the allowed in value of parameters?
Both 2.0 and 3.0 OAI.

We should take this chances to cover all possible values.

Copy link
Collaborator

@jackey8616 jackey8616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jackey8616 jackey8616 merged commit 4b2fa72 into lukeautry:master Oct 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@RequestProp decorator adds a request-prop parameter in generated Spec
2 participants