-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support string variable in the first argument of @Extension #1677
feat: Support string variable in the first argument of @Extension #1677
Conversation
Hello, @WoH , if you have time can you take a look at this CI build error please? Looks like lru-cache had some updates last week which might be causing this? are some package updates appropriate? |
Should be fixed now, can you rebase? |
ffc6c46
to
a865a2c
Compare
Cool, all works well now. Thanks. |
All Submissions:
Closing issues
closes #1520
Adds support of string identifiers to be passed into
@Extension
's attribute key.This is accomplished by adding
ts.isIdentifier
checks intogetExtensions
. If it is an identifier ->getInitializerValue()
If this is a new feature submission:
Potential Problems With The Approach
Test plan
I added test case to the existing extensions tests.