Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1289: values with operator is not properly handled @ decorators #1319

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

jackey8616
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

closes #1289

@jackey8616 jackey8616 changed the title Fix/#1289: values with operator is not properly handled @ decorators Fix/1289: values with operator is not properly handled @ decorators Oct 6, 2022
@jackey8616
Copy link
Collaborator Author

@WoH Please review, thanks.

Add both plus(+) and minus(-) operator @ ExampleDecorator.
Apply to both spec2 & 3 test cases.
Add minus(-) and plus(+) operator detection @ getInitializerValue when
metadataGenerating.
@jackey8616
Copy link
Collaborator Author

Currently I only implement minus(-) and plus(+) operator.
The example case can be find in commit c92ee38.

And the latest force-push is rebased to master.
Since I fixed the test @ #1320 .
Now is able to review.

@WoH thanks.

@WoH
Copy link
Collaborator

WoH commented Oct 7, 2022

LGTM, thanks!

@WoH WoH merged commit 72a8f7d into lukeautry:master Oct 7, 2022
@jackey8616 jackey8616 deleted the fix/1289 branch October 15, 2022 09:44
@jackey8616 jackey8616 restored the fix/1289 branch January 30, 2023 04:41
@jackey8616 jackey8616 deleted the fix/1289 branch January 30, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example response attributes with negative values are omitted from swagger.json file
2 participants