Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a github action #1118

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Added a github action #1118

merged 3 commits into from
Nov 1, 2021

Conversation

Jassi10000-zz
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.
closes #1116

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

@Jassi10000-zz
Copy link
Contributor Author

@WoH Please review this

Comment on lines 18 to 28
issue-message: |
Hello there ${{ github.actor }} 👋

Welcome to tsoa !!💖🥳

Thank you and congratulations 🎉 for opening your very first issue in this project. tsoa fosters an open and welcoming environment for all our contributors.🌸

Incase you want to claim this issue, please comment down below! We will try to get back to you as soon as we can.👀

👩‍💻 If you have any interesting ideas, just open an issue. We would love to hear you and engage in discussions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a bot message for every first time someone opens an issue may be too noisy. Let's focus on a good PR message instead.


Thank you and congrats 🎉 for opening your first PR on this project.✨

tsoa fosters an open and welcoming environment for all our contributors.🌸
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we should (have to) mention that explicitly.

@Jassi10000-zz
Copy link
Contributor Author

@WoH No issues
Just tell what changes you would love to see , I will make them right away !!!!

Comment on lines 18 to 28
issue-message: |
Hello there ${{ github.actor }} 👋

Welcome to tsoa !!💖🥳

Thank you and congratulations 🎉 for opening your very first issue in this project. tsoa fosters an open and welcoming environment for all our contributors.🌸

Incase you want to claim this issue, please comment down below! We will try to get back to you as soon as we can.👀

👩‍💻 If you have any interesting ideas, just open an issue. We would love to hear you and engage in discussions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
issue-message: |
Hello there ${{ github.actor }} 👋
Welcome to tsoa !!💖🥳
Thank you and congratulations 🎉 for opening your very first issue in this project. tsoa fosters an open and welcoming environment for all our contributors.🌸
Incase you want to claim this issue, please comment down below! We will try to get back to you as soon as we can.👀
👩‍💻 If you have any interesting ideas, just open an issue. We would love to hear you and engage in discussions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removal of whole message
What I should I add then ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in my opinion.
However, I'd be fine with a very short and sweet message like:

Hello there ${{ github.actor }} 👋
Thank you for opening your very first issue in this project. We will try to get back to you as soon as we can.👀

@WoH
Copy link
Collaborator

WoH commented Nov 1, 2021

Added the comments as suggestions.

@Jassi10000-zz
Copy link
Contributor Author

@WoH Can you review the latest made changes

@WoH
Copy link
Collaborator

WoH commented Nov 1, 2021

LGTM, thank you and congrats on your first PR here!

@WoH WoH merged commit 59a3587 into lukeautry:master Nov 1, 2021
@Jassi10000-zz
Copy link
Contributor Author

LGTM, thank you and congrats on your first PR here!

Thank you for the opportunity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to add a github action to the repo
3 participants