-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed usage of correct types in enums #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, but mainly one request: There's a similar enum handling happening for OpenAPI 2 here. Please make sure we don't diverge when we don't have to.
Please rebase so the CI fixes from the main branch are applied. |
I am not sure about OAS 2 - the issue was placed for OAS 3 and I am not sure how the enum handling is supposed to look for OAS 2. If its similar then we can apply it there.
Done. |
Should follow the same logic |
Alright, great - all done @WoH ! Thanks for the suggestions 🚀 |
All Submissions:
Closing issues
Put
closes #1068
in your comment to auto-close the issue that your PR fixes.If this is a new feature submission:
(in some sense it yes, so I'll fill this one out, too)
Potential Problems With The Approach
Only targets OAS 3, but this seems to be the target of the issue (and is the current / default spec). It might be "breaking", but then again, it's only the OAS output and not the validator. Since this one even follows OAS more closely than beforehand I doubt it should have any negative impact though. Tooling etc. would like the "new style" even more than the old one.
Test plan
Some existing tests only build upon strings, essentially dealing with it the same way that the bug appeared in the first place. I've adjusted them to the desired behavior.