fixup! cpp-subprocess: Iterate through /proc/self/fd for close_fds op…

…tion
luke-jr · Aug 29, 2024 · 6a3967f · 6a3967f
1 parent 7fff94a
commit 6a3967f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/util/subprocess.h b/src/util/subprocess.h
@@ -1305,7 +1305,7 @@ namespace detail {
       // Close all the inherited fd's except the error write pipe
       if (parent_->close_fds_) {
         try {
-            for (auto it : fs::directory_iterator("/proc/self/fd")) {
+            for (const auto& it : fs::directory_iterator("/proc/self/fd")) {
                 int64_t fd;
                 if (!ParseInt64(it.path().filename().native(), &fd)) continue;
                 if (fd <= 2) continue;  // leave std{in,out,err} alone