Disable hoverClass when disabling or destroying sortable element #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/html5sortable.ts
Outdated
| @@ -145,6 +145,9 @@ const destroySortable = function (sortableElement) { | |||
| const opts = data(sortableElement, 'opts') || {} | |||
| const items = filter(sortableElement.children, opts.items) | |||
| const handles = getHandles(items, opts.handle) | |||
| // disable adding hover class | |||
| console.log(opts) | |||
There was a problem hiding this comment.
You forgot a console.log here, can you please delete it, thanks.
There was a problem hiding this comment.
Oops. My bad 😄
|
Hey @mateuszpigula, This looks great and I am happy to test & merge it. Can you just quickly remove the one console.log that is still in there? Thanks |
lukasoppermann
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
It adds
enableHoverClass(sortableElement, false)indestroySortablemethod anddisableSortablemethod.I wanted to add tests to either
hoverClass.test.tsorapi.test.tshowever:hoverClassI wasn't able to usesortable(ul, 'disable')properly.api.testcustom eventmousemoveis not triggering adding the hover class (of course I added this to config).Do not mince words please, it is my first contribution to open source ever 😄