-
-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update rollup-plugin-typescript to rollup-plugin-typescript2 #568
base: master
Are you sure you want to change the base?
Conversation
Bumps [tar](https://github.com/npm/node-tar) from 4.4.1 to 4.4.13. **This update includes security fixes.** - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/master/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.1...v4.4.13) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [rollup](https://github.com/rollup/rollup) from 2.29.0 to 2.30.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.29.0...v2.30.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.4.0 to 4.4.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.4.1/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.4.0 to 4.4.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.4.1/packages/parser) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [rollup](https://github.com/rollup/rollup) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.30.0...v2.31.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Can you add this to commit log and also rebase b/c the latest master branch updated a bunch of other dependencies. Otherwise LGTM so not sure why the subject says "WIP". |
…html5sortable into update-typescript-plugin
Ok, have done the changes. I included WIP in the title because there are a lot of other error down the line. I removed the IE fix but I cannot check if it is used because IE11 is still not working ( #445 ). The problems are typescript errors, every usage of options is using the configuration type but it also has other types. html5sortable/src/html5sortable.ts Lines 230 to 237 in a19d778
So I could add a <configuration> before every usage of options but I don't think this is the best solution. I haven't found out when the object string or undefined type on options is used, so we could maybe remove them and write:options: configuration
|
All the errors look like this:
|
Hey @kaffarell please verify what I am saying, but I think you could cast options to here: html5sortable/src/html5sortable.ts Line 267 in a19d778
Otherwise we would probably need to add a function that deals with the options parameter and returns a configuration, but try the above mentioned first please. |
@kaffarell any news so this can be made mergable? |
Will fix #560