Add Geode Provider

[ghost]

No description provided.

[lukas-krecan]

Thanks a lot, I will look at it in next few days.

[lukas-krecan]

I am not able to run the test. Locally it throws java.lang.NoClassDefFoundError: org/apache/geode/management/internal/cli/result/ResultData and on CI it fails like this https://travis-ci.org/github/lukas-krecan/ShedLock/jobs/677620230 Can you please fix it?

[codecov-io]

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #235   +/-   ##
=========================================
  Coverage     86.02%   86.02%           
  Complexity      334      334           
=========================================
  Files            67       67           
  Lines          1331     1331           
  Branches         69       69           
=========================================
  Hits           1145     1145           
  Misses          163      163           
  Partials         23       23           

Impacted Files	Coverage Δ	Complexity Δ
...mbs/shedlock/provider/mongo/MongoLockProvider.java	86.66% <0.00%> (ø)	8.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3f6d0...6e6b1d8. Read the comment docs.

[ghost]

I think the build failed as the module wasnt mentioned in pom.xml , wondering how it got picked up for build and test , anyways have updated the blocking unlock to asynchronous unlock.
Have also updated the pom.xml.

Please take a look .

[ghost]

Ok sorted out the java docs error , checking on the jacoco coverage error ( plugin is saying unable to create coverage , but works fine on local ) , probably as the test starts vm outside of the Testcase , probably its not able to pick up the coverage.

Also i see we have used jupiter for test rules , somehow intellij doesnt like it and complains for each testSuite that the jupiter-platform jar is unavailable , any suggestions ?

[lukas-krecan]

Thank, I will look at it over weekend.

[lukas-krecan]

Hi, it seems that the tests still do not work. If I execute GeodeLockProviderIntegrationTest it does not run any tests. Can you please fix it? The cause might be that the test is mixing JUnit 4 and 5 annotations.

[ghost]

Looking at it now .

[ghost]

Hi Lukas,
The build is failing on travis with the error "maximum" log limit exceed and terminating the jobs.Please can you increase the log limit ? If not possible to increase length , can comment out all other modules

[lukas-krecan]

Thanks a lot, will take a look at it

[lukas-krecan]

Some of the builds are passing, so feel free to ignore the issue. I will fix it later.

[ghost]

Ok thanks

Reference tried to fix openJDK issue , https://travis-ci.org/github/lukas-krecan/ShedLock/builds/679451966

However i had to downgrade geode to 1.9.2 , so if we can solve the openJDK issue then please let me know , ideally i would want to use 1.10 as currently 1.12 is latest.

[lukas-krecan]

Hi, I am really sorry but Geode is so complex that I am afraid I would not be able to maintain it. I would recommend to create a third party lock provider similar to the one for CosmosDB https://github.com/jesty/shedlock-provider-cosmosdb

[ghost]

Hi
Not sure what the issue , jdk8 build is passing and the underlying complexity is same as hazelcast.
If you want I can take a look at openJdK build again.

[lukas-krecan]

I managed to get the tests running with test containers but the necessity to deploy the DistributedLockFunction makes automated testing and deployment quite complex. There is nothing like that needed in Hazelcast. I am afraid I will not be able to maintain this code so it would be better if you published it as third party module.