Make Spring integration with InterceptMode.PROXY_METHOD work for Spring versions prior to 5.0.0 #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng versions prior to 5.0.0.
|
Hi, thanks for your contribution. I don't see why to support Spring 4.3. It's really old and unsupported. Maybe an old version of ShedLock will work with it. |
|
I realize that Spring 4 went EOL in 2020, however I am currently tasked with maintaining a legacy application stuck at said version. Sadly, I know of a significant number of productive applications in large corporations in the same situation. If you don't want to support it, I suggest to document version compatibilities in more detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ShedLock 4.x in a Spring Boot 1.5/Spring 4.3 application with InterceptMode.PROXY_METHOD, this fails with
NoSuchMethodErrordue to usage of anAnnotationMatchingPointcutconstructor that was added in Spring 5.0.0.It can easily be made to work by checking the Spring major version and using the appropriate constructor. With this fix, Spring 4.x-based applications should work again.