Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project doesn't seem to be working for main OSs #6

Closed
luizperes opened this issue Mar 3, 2019 · 5 comments
Closed

Project doesn't seem to be working for main OSs #6

luizperes opened this issue Mar 3, 2019 · 5 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed high priority high priority problems mac os Problems in mac OS platform windows Problems in Windows platform

Comments

@luizperes
Copy link
Owner

It seems that simd_nodejs on the master branch is only currently working for Linux (the current tag version 0.0.2 on npm has only been tested with Mac and seems to be fine.

At the moment, we have two reported error in Windows and Mac:

d142-058-221-020:simdjson_nodejs luizperes$ npm run build

> [email protected] build /Users/luizperes/Projects/simdjson_nodejs
> node-gyp rebuild

  CC(target) Release/obj.target/nothing/node_modules/node-addon-api/src/nothing.o
  LIBTOOL-STATIC Release/nothing.a
  CXX(target) Release/obj.target/simdjson/simdjson/main.o
In file included from ../simdjson/main.cpp:2:
In file included from ../simdjson/bindings.h:2:
../simdjson/src/simdjson.h:74:2: warning: "BMI is missing?" [-W#warnings]
#warning "BMI is missing?"
 ^
../simdjson/src/simdjson.h:35739:2: warning: "We require AVX2 support!" [-W#warnings]
#warning "We require AVX2 support!"
 ^
2 warnings generated.
  CXX(target) Release/obj.target/simdjson/simdjson/bindings.o
In file included from ../simdjson/bindings.cpp:1:
In file included from ../simdjson/bindings.h:2:
../simdjson/src/simdjson.h:74:2: warning: "BMI is missing?" [-W#warnings]
#warning "BMI is missing?"
 ^
../simdjson/src/simdjson.h:35739:2: warning: "We require AVX2 support!" [-W#warnings]
#warning "We require AVX2 support!"
 ^
2 warnings generated.
  CXX(target) Release/obj.target/simdjson/simdjson/src/simdjson.o
In file included from ../simdjson/src/simdjson.cpp:2:
../simdjson/src/simdjson.h:74:2: warning: "BMI is missing?" [-W#warnings]
#warning "BMI is missing?"
 ^
../simdjson/src/simdjson.h:35739:2: warning: "We require AVX2 support!" [-W#warnings]
#warning "We require AVX2 support!"
 ^
../simdjson/src/simdjson.cpp:408:34: error: variable has incomplete type 'struct avx_processed_utf_bytes'
  struct avx_processed_utf_bytes previous{};
                                 ^
../simdjson/src/simdjson.cpp:408:10: note: forward declaration of 'avx_processed_utf_bytes'
  struct avx_processed_utf_bytes previous{};
         ^
2 warnings and 1 error generated.
make: *** [Release/obj.target/simdjson/simdjson/src/simdjson.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/luizperes/Projects/simdjson_nodejs
gyp ERR! node -v v10.14.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] build: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/luizperes/.npm/_logs/2019-03-03T08_12_36_813Z-debug.log

It seems that the flags __AVX2__ and BMI are not being recognized on Mac OS (it was tested outside npm and runs fine)

@luizperes luizperes self-assigned this Mar 3, 2019
@luizperes luizperes added bug Something isn't working help wanted Extra attention is needed windows Problems in Windows platform high priority high priority problems mac os Problems in mac OS platform WIP Work in progress labels Mar 3, 2019
@luizperes
Copy link
Owner Author

luizperes commented Mar 4, 2019

Here goes a list of the tested OSs. for current npm version 0.0.3:

  • Linux
  • Mac OS
  • Windows

luizperes added a commit that referenced this issue Mar 4, 2019
luizperes added a commit that referenced this issue Mar 4, 2019
@luizperes
Copy link
Owner Author

Help needed for windows, removing that from WIP since I don't have a windows machine

@luizperes luizperes removed the WIP Work in progress label Jul 8, 2019
@lemire
Copy link
Contributor

lemire commented Jul 19, 2019

This may get resolved with the next version of simdjson. Upstream, simdjson will provide runtime dispatch.

cc @ioioioio

@luizperes
Copy link
Owner Author

Hi @lemire, I still need help for testing if it is working on Windows. For this reason I won't close it right now, cheers!

cc @ioioioio

@luizperes
Copy link
Owner Author

PR #27 fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed high priority high priority problems mac os Problems in mac OS platform windows Problems in Windows platform
Projects
None yet
Development

No branches or pull requests

2 participants