Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeneratedDotEnv.m as an output file #751

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

abejfehr
Copy link
Contributor

@abejfehr abejfehr commented May 8, 2023

Why

Locally I can build my app just fine, but when I do:

rm -rf node_modules && yarn install && yarn ios-install # (cocoapods)

the subsequent builds fail, and the only way they succeed again is if I clear the DerivedData folder before building.

This is the output when I build after nuking my node_modules folder:

The following build commands failed:
        CompileC /Users/abejfehr/Library/Developer/Xcode/DerivedData/MyApp-abcd1234/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-config.build/Objects-normal/x86_64/ReactNativeConfig.o /Users/abejfehr/my-app/node_modules/react-native-config/ios/ReactNativeConfig/ReactNativeConfig.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-config' from project 'Pods')

So this actually makes sense — the ruby script to produce GeneratedDotEnv.m doesn't get re-ran because its inputs/outputs didn't change, but that's because GeneratedDotEnv.m isn't part of the inputs or outputs.

What

This PR adds the GeneratedDotEnv.m to the outputs of the build script that produces it, so that it gets regenerated when necessary.

@Ingibjorg
Copy link

Confirmed that this fixes the issue on our end! Thanks @abejfehr!

@luancurti
Copy link
Collaborator

Thank You @abejfehr

@luancurti luancurti merged commit 6103770 into lugg:master May 15, 2023
@luancurti
Copy link
Collaborator

Published Version 1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants