-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Most Recent Version of matplotlib breaks ptitprince and seaborn method calls. #4007
Conversation
…s library version.
…nsformers library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I wonder why they'd make a hard requirement change of explicitly setting the generation config though
@@ -563,6 +563,8 @@ def save(self, save_path): | |||
# avoid this hack | |||
if self.config_obj.trainer.type != "none": | |||
weights_save_path = os.path.join(save_path, MODEL_WEIGHTS_FILE_NAME) | |||
# We initialize the model's generation configuration; otherwise, we get a validation error. | |||
self.model.generation_config = self.generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fascinating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnavgarg1 Yes, and they also changed the ViTModel
(I filed an issue: huggingface/transformers#30978). Unless you recommend changes, may I please get an approval so that @ethanreidel can continue his work? Thanks!
… seaborn method calls. (ludwig-ai#4007)
Scope
matplotlib
to"<3.9.0"
, because the latter (released on 5/15/2024), cause API incompatibilities:thus breaking the tests collection. Pinning the version of
matplotlib
fixes this issue. We will keep an eye on the futurematplotlib
releases, which might render the pinning of its version unnecessary.ViTEncoder
to ensure that thetransformers.ViTModel
returns theoutput_attentions
.Code Pull Requests
Please provide the following:
Documentation Pull Requests
Note that the documentation HTML files are in
docs/
while the Markdown sources are inmkdocs/docs
.If you are proposing a modification to the documentation you should change only the Markdown files.
api.md
is automatically generated from the docstrings in the code, so if you want to change something in that file, first modifyludwig/api.py
docstring, then runmkdocs/code_docs_autogen.py
, which will createmkdocs/docs/api.md
.