Reordered package for future development #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludeeus
approved these changes
Nov 24, 2018
ludeeus
added a commit
that referenced
this pull request
Nov 25, 2018
* Cleanup (#1) * Added set_eureka_info and enable_control_notifications (#2) * Added set_eureka_info and enable_control_notifications * rename to control_notifications * Reordered package for future development (#4) * reordered package * fixed examples * Adds initial CLI tool (#5) * Initial inclution of a CLI * Linting * docstring * linting * remove if * remove print from reboot commands * remove var for reboot result * added more requirements to setup * Use single eventloop * remove json from requirements * fixes linting issue * Move scan to utils (#6) * Move scan to utils * Forgot one refrence * Add filter and defaults to network scan (#8) * Add filter and defaults to network scan * Added alarm volume control (#7) * Added alarm volume control * added docstrings 😉 * 🤴 imperative mood * simplify cli commands (#9) * simplify cli commands * missing 1 blank line * tuple does not have get (#10) * move from dict[key] to dict.get(key) * tuple does not have get * Preperations fo 0.5.0 release (#11) * Preperations fo 0.5.0 release * README update
Merged
eliseomartelli
pushed a commit
that referenced
this pull request
Nov 25, 2018
* Cleanup (#1) * Added set_eureka_info and enable_control_notifications (#2) * Added set_eureka_info and enable_control_notifications * rename to control_notifications * Reordered package for future development (#4) * reordered package * fixed examples * Adds initial CLI tool (#5) * Initial inclution of a CLI * Linting * docstring * linting * remove if * remove print from reboot commands * remove var for reboot result * added more requirements to setup * Use single eventloop * remove json from requirements * fixes linting issue * Move scan to utils (#6) * Move scan to utils * Forgot one refrence * Add filter and defaults to network scan (#8) * Add filter and defaults to network scan * Added alarm volume control (#7) * Added alarm volume control * added docstrings 😉 * 🤴 imperative mood * simplify cli commands (#9) * simplify cli commands * missing 1 blank line * tuple does not have get (#10) * move from dict[key] to dict.get(key) * tuple does not have get * Preperations fo 0.5.0 release (#11) * Preperations fo 0.5.0 release * README update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reordered the package so now everything under
apicontains device communication logic.