Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow find_first_match without ensure_strategy #173

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Do not allow find_first_match without ensure_strategy #173

merged 2 commits into from
Jul 7, 2022

Conversation

ludeeus
Copy link
Owner

@ludeeus ludeeus commented Jul 7, 2022

Proposed change

find_first_match is not used without ensure_strategy, now it will raise when ensure_strategy is missing to guard against misconfiguration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionalit)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • The code has been formatted using Black (make black)
  • Tests have been added to verify that the new code works.

@ludeeus ludeeus merged commit def202c into main Jul 7, 2022
@ludeeus ludeeus deleted the Do-not-allow-find_first_match-without-ensure_strategy branch July 7, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ludeeus