[Level 2] In progress #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckymark
reviewed
Mar 13, 2021
level2/SkipList/1.cpp
Outdated
| for(int i=0;i<Limit;++i)A[S].Next[i]=T; | ||
| } | ||
|
|
||
| inline int find(const int &k){ |
There was a problem hiding this comment.
这种函数不太可能被inline掉的，此处的inline还是去掉吧
There was a problem hiding this comment.
以前写inline就是为了减少函数调用，卡下常数。然后觉得反正不能内联的编译器都会自动处理掉，就一直顺手写了。现在去看了点资料，感觉又涨知识了:)
luckymark
reviewed
Mar 15, 2021
level2/SkipList/1.cpp
Outdated
| build(); | ||
| while(1){ | ||
| int k,v; | ||
| switch(getchar()){ |
There was a problem hiding this comment.
建议直接构造数组来测试，如果有兴趣的话，还可以看看TDD（测试驱动开发）https://www.jianshu.com/p/5ea25ceeccc4
There was a problem hiding this comment.
哈哈哈，感谢，我自己造数据发现了一个bug
另外我发现直接rand()分层跑得确实很慢，所以修改了选层函数，现在期望复杂度感觉正确了
Bug fix. Generating testcase and test added. Changed the way to choose level of nodes.
文件过大，分成了4份
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.