Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-14728 - TopLevelJoinQuery - same core + same field optimization #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nddipiazza
Copy link

Description

Do not do the convertFromOrdinalsIntoToField lookup when same core and same field.

Solution

Detect when "to" and "from" are both from same searcher and the same field. If so, use the same ordinal bit set.

Tests

I am testing using this to optimize the usage of the TopLevelJoinQuery for use with document permissions filters.

The query to test this is:

{!join from=acl_ss to=acl_ss method=topLevelDV}{!graph from=inbound_ss to=outbound_ss}id:ndipiazza

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).

…d name, then do not call the convertFromOrdinalsIntoToField method
nddipiazza added a commit to nddipiazza/lucene-solr that referenced this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant