SOLR-14728 - TopLevelJoinQuery - same core + same field optimization #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not do the
convertFromOrdinalsIntoToField
lookup when same core and same field.Solution
Detect when "to" and "from" are both from same searcher and the same field. If so, use the same ordinal bit set.
Tests
I am testing using this to optimize the usage of the TopLevelJoinQuery for use with document permissions filters.
The query to test this is:
Checklist
Please review the following and check all that apply:
master
branch../gradlew check
.