Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New settings icon - replacement? #296

Merged
merged 6 commits into from May 16, 2021
Merged

New settings icon - replacement? #296

merged 6 commits into from May 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 22, 2021

Hello, just adding this file because I personally don't really like the original settings icon. I used SVGOMG, changed the color to "currentColor" and put all metadata in the tag. This is how it looks
image
and the 100% scale
settings-2

@mittalyashu
Copy link
Member

After optimising

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M11.967 2h-.434a2 2 0 00-2 2v.18a2 2 0 01-.999 1.731l-.435.252a2 2 0 01-2.003 0l-.144-.084a2 2 0 00-2.735.733l-.22.383a2 2 0 00.73 2.73l.155.088a2 2 0 01.998 1.732v.51a2 2 0 01-.998 1.731l-.154.09a2 2 0 00-.732 2.73l.221.382a2.001 2.001 0 002.735.733l.144-.084a2 2 0 012.003 0l.435.252a2 2 0 01.999 1.731V20a2 2 0 002 2h.434a2 2 0 002-2v-.18a2 2 0 01.999-1.731l.435-.252a2 2 0 012.003 0l.144.084a2.002 2.002 0 002.735-.733l.22-.383a2 2 0 00-.73-2.73l-.155-.088a2 2 0 01-.998-1.732v-.51a2 2 0 01.998-1.731l.154-.09a2 2 0 00.732-2.73l-.221-.382a1.999 1.999 0 00-2.735-.733l-.144.084a2 2 0 01-2.003 0l-.435-.252a2 2 0 01-.999-1.731V4a2 2 0 00-2-2v0z" />
  <path d="M11.75 14a2.25 2.25 0 100-4.5 2.25 2.25 0 000 4.5z" />
</svg>

@ghost
Copy link
Author

ghost commented Apr 24, 2021

I already optimized it, but if you want the attributes to look like this, why not.

@mittalyashu
Copy link
Member

@delnyn The icon should have path tag, not circle.

@ericfennis
Copy link
Member

@delnyn @mittalyashu I think this icon is too similar with the current settings icon. So I'm more for a replacement instead of a second one.

Can you maybe post an a side-by-side image with the two settings icons?

@mittalyashu
Copy link
Member

@ericfennis After looking at this icon I think this looks more cleaner with less curvy lines and it will even look better when stroke-width is increased.

@ghost
Copy link
Author

ghost commented Apr 28, 2021

image

@ghost ghost changed the title Add the settings-2 icon New settings icon - replacement? Apr 28, 2021
@ericfennis
Copy link
Member

I agree with you @mittalyashu this icon is much cleaner. Also better for lower resolution screens.
I think the icon look a bit better by increasing the circle in the middle, but I don't know what you think.
image
@delnyn I noticed that the code of the icon, the icon is a bit shifted to left. You can also see that in the preview you posted.

@ghost
Copy link
Author

ghost commented Apr 30, 2021

I think the icon look a bit better by increasing the circle in the middle, but I don't know what you think.

Yes, I had that idea too!

I noticed that the code of the icon, the icon is a bit shifted to left. You can also see that in the preview you posted.

Actually it's because the outside path is 20h x 19.5w and that's pretty hard to deal with, I'll try to change that

@ghost
Copy link
Author

ghost commented Apr 30, 2021

I made the icon centered, the circle 6px wide, removed settings-2 tags, made the attributes cleaner, and replaced settings with settings-2

@mittalyashu
Copy link
Member

To decrease the size of first node, I tried to split into 4 path, it didn't work.

CleanShot 2021-05-01 at 11 44 57@2x

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code improvements

icons/settings.svg Outdated Show resolved Hide resolved
Co-authored-by: Eric Fennis <[email protected]>
@ghost
Copy link
Author

ghost commented May 5, 2021

To decrease the size of first node, I tried to split into 4 path, it didn't work.

WDYM by "It didn't work"? What didn't work?

@mittalyashu
Copy link
Member

@delnyn This is what I mean.

CleanShot 2021-05-06 at 08 53 17@2x

Split into 4 different path.

@ericfennis ericfennis merged commit 66f2dc2 into lucide-icons:master May 16, 2021
@ghost ghost deleted the add-settings-2 branch August 2, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants