Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): optimised puzzle icon #2603

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

jamiemlaw
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other: icon update

Description

Redraws a number of curves as arcs, simplifying the total number of path segments.

Before Submitting

Redraw some bezier curves as arcs
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 11, 2024
Copy link

Added or changed icons

icons/puzzle.svg

Preview cohesion icons/square-square.svg
icons/puzzle.svg
icons/philippine-peso.svg
Preview stroke widths icons/puzzle.svg
icons/puzzle.svg
icons/puzzle.svg
DPI Preview (24px) icons/puzzle.svg
Icon X-rays icons/puzzle.svg
Icon Diffs icons/puzzle.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PuzzleIcon = createLucideIcon('Puzzle', [
  ["path",{"d":"M15.39 4.39a1 1 0 0 0 1.68-.474 2.5 2.5 0 1 1 3.014 3.015 1 1 0 0 0-.474 1.68l1.683 1.682a2.414 2.414 0 0 1 0 3.414L19.61 15.39a1 1 0 0 1-1.68-.474 2.5 2.5 0 1 0-3.014 3.015 1 1 0 0 1 .474 1.68l-1.683 1.682a2.414 2.414 0 0 1-3.414 0L8.61 19.61a1 1 0 0 0-1.68.474 2.5 2.5 0 1 1-3.014-3.015 1 1 0 0 0 .474-1.68l-1.683-1.682a2.414 2.414 0 0 1 0-3.414L4.39 8.61a1 1 0 0 1 1.68.474 2.5 2.5 0 1 0 3.014-3.015 1 1 0 0 1-.474-1.68l1.683-1.682a2.414 2.414 0 0 1 3.414 0z"}]
])

@jamiemlaw jamiemlaw changed the title Optimise puzzle icon fix(icons): optimised puzzle icon Nov 11, 2024
Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corners have a radius of 2.4, maybe we can make them sharper to be 2.

@jamiemlaw
Copy link
Contributor Author

jamiemlaw commented Nov 12, 2024

If that were the only change, it would bring the corners too close to the edge of frame.

Trying some slight redraws with the goal to keep the diagonal lines on-grid. These aren't final, but they illustrate a couple of potential issues:

icons
Open lucide studio

The north-each and south-west sticky-out-bits are now aligned to half pixels, making them blurry at low resultions

icons
Open lucide studio

Bringing them in further and the optical volume is somewhat reduced from what it was previously, and it introduces some 2-pixel-gap violations.

@ericfennis ericfennis merged commit 8700418 into lucide-icons:main Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants