-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added bangladeshi-taka
icon
#2416
feat(icons): added bangladeshi-taka
icon
#2416
Conversation
- BDT - ৳ - ISO 4217 - Unicode: U+09F3
Added or changed iconsIcons as codeWorks for: const BadgeBangladeshiTakaIcon = createLucideIcon('BadgeBangladeshiTaka', [
["path",{"stroke-width":"1.5","d":"M8.92 7.83c1.83-.25 1.69 1.04 1.66 3.67v3.79c-.05 1.44 2.08 2.11 3.52 1.12.92-.64.87-1.63.54-2.14M9 11h6"}],
["path",{"stroke-width":"1.5","d":"M3.85 8.62a4 4 0 0 1 4.78-4.77 4 4 0 0 1 6.74 0 4 4 0 0 1 4.78 4.78 4 4 0 0 1 0 6.74 4 4 0 0 1-4.77 4.78 4 4 0 0 1-6.75 0 4 4 0 0 1-4.78-4.77 4 4 0 0 1 0-6.76Z"}]
])
const BangladeshiTakaIcon = createLucideIcon('BangladeshiTaka', [
["path",{"stroke-width":"1.5","d":"M7 4.16C10.48 3.17 9.89 6.94 9.93 10.88V18.24C9.96 21.14 13.79 21.82 16.46 19.98C18.77 18.37 18.42 15.63 15.83 15.57M7 10H14"}]
])
const ReceiptBangladeshiTakaIcon = createLucideIcon('ReceiptBangladeshiTaka', [
["path",{"stroke-width":"1.5","d":"M4 2v20l2-1 2 1 2-1 2 1 2-1 2 1 2-1 2 1V2l-2 1-2-1-2 1-2-1-2 1-2-1-2 1-2-1Z"}],
["path",{"stroke-width":"1.5","d":"M9 7.88c1.88-.54 1.56 1.5 1.58 3.62V15.47c.01 1.56 2.08 1.93 3.52.94 1.25-.87 1.06-2.35-.34-2.38M9 11h3.72"}]
]) |
bangladeshi-taka
icon
Hi @mayeenulislam, I'm afraid these have several guideline violations, please make sure to more closely follow our icon design guidelines. The main issues that need to be addressed:
More Lucide-ey proposas, based on Google image search (but I'm totally unsure if they're recognisable or good enough): |
We should maybe rethink the currency icons, we basically have the same issues here as we do with the brand icons where we try to shoehorn existing possibly copyrighted work into our design guidelines. For example |
@karsa-mistmere I've revised the design, as far as I understood your design guidelines and the previous icons that you already have merged. I did not find any dedicated pull request on "Indian Rupee" (except #1401), and I could not measure the deviations. BTW, about the DPI (24px) I checked the Rupee symbols in Figma and the symbols that I designed. In the 1px grid, they completely matched in many ways. Given my current understanding, I believe these modifications will align the design with the guidelines. |
I'm afraid every concern raised in my original review still stands: the vertical lines are off grid, gaps are too small, curvatures are uneven (especially for the base icon). |
@karsa-mistmere I've updated the Icons once again. Pardon me, would love to have another final review. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
What is the purpose of this pull request?
Description
Adding a new icon: "Bangladeshi Taka"
Icon use case
A real-life currency — also used as Money, Shopping, Discount
Alternative icon designs
No alternative icon designs. It's the universal "Taka" icon
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting