Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scale icon #205

Merged
merged 2 commits into from
Apr 23, 2021
Merged

add scale icon #205

merged 2 commits into from
Apr 23, 2021

Conversation

mittalyashu
Copy link
Member

Preview
CleanShot 2021-02-03 at 22 24 49@2x

@ericfennis ericfennis added the 🎨 icon About new icons label Feb 4, 2021
@ericfennis
Copy link
Member

@mittalyashu Hmm I think we can refine this icon some more.
Are you ok if I give it a try?

@mittalyashu
Copy link
Member Author

Sure

@ericfennis
Copy link
Member

@mittalyashu
What do you think of this?
image

@mittalyashu
Copy link
Member Author

mittalyashu commented Mar 9, 2021

@ericfennis can you add 1px more spacing here

Preview
CleanShot 2021-03-09 at 17 21 09@2x

@ericfennis
Copy link
Member

@mittalyashu Like this?

image

100%
Frame 63

@mittalyashu
Copy link
Member Author

@ericfennis The spacing looks fine to me, what about adding a curvy slant on both left and right side?

@ericfennis
Copy link
Member

@mittalyashu Mneeh I'm not really fan of it, I think we should keep it simple.
image

@mittalyashu
Copy link
Member Author

@ericfennis thats not what I mean.

Can you provide the source of the icon?

@ericfennis
Copy link
Member

ericfennis commented Mar 15, 2021

@mittalyashu Yes of course!

<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M16 16L19 8L22.001 16C21.1353 16.649 20.0825 16.9999 19.0005 16.9999C17.9185 16.9999 16.8657 16.649 16 16Z" stroke="black" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M2 16L5 8L8.001 16C7.1353 16.649 6.08248 16.9999 5.0005 16.9999C3.91852 16.9999 2.8657 16.649 2 16Z" stroke="black" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M7 21H17" stroke="black" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M12 3V21" stroke="black" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M3 7H7L12 5L17 7H21" stroke="black" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/>
</svg>

@ericfennis
Copy link
Member

@mittalyashu I think the icons looks better without slant.

@mittalyashu
Copy link
Member Author

mittalyashu commented Apr 23, 2021

@ericfennis That's what I mean by adding curves. What do you think?

CleanShot 2021-04-23 at 19 57 46@2x

@ericfennis
Copy link
Member

@mittalyashu looks great, I think this is the one.

@vercel
Copy link

vercel bot commented Apr 23, 2021

@mittalyashu is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@mittalyashu
Copy link
Member Author

@ericfennis LGTM

@vercel
Copy link

vercel bot commented Apr 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lucide/lucide/FUCjv2ukd3YoRY7R6Ezqn6NjTyJe
✅ Preview: https://lucide-git-fork-mittalyashu-icon-scale-lucide.vercel.app

@ericfennis
Copy link
Member

Looks good!

@ericfennis ericfennis merged commit 2a8f734 into lucide-icons:master Apr 23, 2021
@mittalyashu mittalyashu deleted the icon/scale branch May 1, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants