Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image-minus icon #191

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

mittalyashu
Copy link
Member

Preview
CleanShot 2021-02-02 at 15 03 42@2x

@mittalyashu
Copy link
Member Author

@ericfennis can you run the refactor icon script magic on this PR too.

@ericfennis
Copy link
Member

@csandman worked on this. yarn optimize is fixing icons, if I'm right. If you experience any issues let us know.

@csandman
Copy link
Contributor

csandman commented Feb 3, 2021

It looks like the precommit hook worked and it's already formatted/optimized! Glad to see it.

@mittalyashu
Copy link
Member Author

@csandman I don't think so, I had to manually run that yarn optimize build to refactor the icons.

@csandman
Copy link
Contributor

csandman commented Feb 3, 2021

@csandman I don't think so, I had to manually run that yarn optimize build to refactor the icons.

Did you try committing the file without running the script? It should optimize during the commit process.

@mittalyashu
Copy link
Member Author

Did you try committing the file without running the script?

The first commit was without refactor, then I had the run the script manually and commit the changes.

It should optimize during the commit process.

Does this script will only run when using terminal instead of GUI app?

@csandman
Copy link
Contributor

csandman commented Feb 3, 2021

@mittalyashu it should be doing it either way, I'll take a look at it tomorrow.

@ericfennis ericfennis added the 🎨 icon About new icons label Feb 3, 2021
@csandman
Copy link
Contributor

csandman commented Feb 3, 2021

@mittalyashu The change to add the pre-commit hook was recent, however it should definitely be working. can you please make sure your package.json file has the following at the bottom in your local version of the repo?

"husky": {
  "hooks": {
    "pre-commit": "lint-staged"
  }
},
"lint-staged": {
  "icons/*.svg": "npx babel-node ./scripts/optimizeStagedSvgs.js --presets @babel/env"
}

And if it does, make sure you run yarn install to get those dependencies set up? I'm very curious if this ends up working!

@ericfennis We might want to add a note in the readme that people should update their local repo before committing any new icons, otherwise people might commit icons which are not consistent with the others and will require future optimization.

@ericfennis ericfennis merged commit 0c460bc into lucide-icons:master Feb 18, 2021
@mittalyashu mittalyashu deleted the icon/image-minus branch May 1, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants