-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image-minus icon #191
add image-minus icon #191
Conversation
mittalyashu
commented
Feb 2, 2021
Preview |
---|
@ericfennis can you run the refactor icon script magic on this PR too. |
@csandman worked on this. |
It looks like the precommit hook worked and it's already formatted/optimized! Glad to see it. |
@csandman I don't think so, I had to manually run that |
Did you try committing the file without running the script? It should optimize during the commit process. |
The first commit was without refactor, then I had the run the script manually and commit the changes.
Does this script will only run when using terminal instead of GUI app? |
@mittalyashu it should be doing it either way, I'll take a look at it tomorrow. |
@mittalyashu The change to add the pre-commit hook was recent, however it should definitely be working. can you please make sure your "husky": {
"hooks": {
"pre-commit": "lint-staged"
}
},
"lint-staged": {
"icons/*.svg": "npx babel-node ./scripts/optimizeStagedSvgs.js --presets @babel/env"
} And if it does, make sure you run @ericfennis We might want to add a note in the readme that people should update their local repo before committing any new icons, otherwise people might commit icons which are not consistent with the others and will require future optimization. |