Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add plug-zap icon #185

Merged
merged 3 commits into from
Apr 23, 2021
Merged

add plug-zap icon #185

merged 3 commits into from
Apr 23, 2021

Conversation

mittalyashu
Copy link
Member

@mittalyashu mittalyashu commented Jan 31, 2021 •
edited
Loading

Old design
Preview
CleanShot 2021-01-31 at 11 50 52@2x
Preview
image

@ericfennis ericfennis added the 🎨 icon About new icons label Jan 31, 2021
@mittalyashu
Copy link
Member Author

@ericfennis How about this?

Preview
CleanShot 2021-02-02 at 15 02 54@2x

@ericfennis
Copy link
Member

@mittalyashu like it!

@mittalyashu
Copy link
Member Author

@ericfennis can you review the PR again?

@ericfennis
Copy link
Member

Nice looks good.
I am a little bit doubting about the name.
I think it should include plug in de name.

plug-zap
plug-power
🤔

@mittalyashu
Copy link
Member Author

@ericfennis How about plug-zap?

@moeenio
Copy link
Contributor

moeenio commented Feb 8, 2021

@ericfennis How about plug-zap?

and then we'd also have plug alone

@ericfennis
Copy link
Member

@mittalyashu plug-zap is allright.

@ericfennis
Copy link
Member

@locness3 Exactly, in this way we keep the icons and variants grouped

ericfennis
ericfennis requested changes Feb 12, 2021
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to plug-zap or something with plug

@moeenio
Copy link
Contributor

moeenio commented Apr 14, 2021

and add a standalone plug

@vercel
Copy link

vercel bot commented Apr 23, 2021

@ericfennis is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@ericfennis ericfennis merged commit 8595777 into lucide-icons:master Apr 23, 2021
@moeenio moeenio changed the title add power-on icon add plug-zap icon Apr 28, 2021
@mittalyashu mittalyashu deleted the icon/power-on branch May 1, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis requested changes

Assignees
No one assigned
Labels
🎨 icon About new icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mittalyashu @ericfennis @moeenio