Revert .mjs modules in build for Lucide React #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Released test package on |
1 task
|
if you don't wanna downgrade next, you can just specify the path to 'lucide-react' module. |
|
Fixed it for me! |
realguse
pushed a commit
to realguse/lucide
that referenced
this pull request
Dec 25, 2024
* switch to different build strategy for dynamicIconImports * add remove for dynamicIconImports files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1446 #1457
Reverting switch to .mjs modules. Probably causing issues in NodeJS because it resolves in a different way than classic
.jsmodules.Not sure if this will fix it but we need to test this if this works.