Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add music/piano/keyboard/guitar/pick/amp/drum/album/audio/waveform icons #1124

Merged
merged 19 commits into from
Nov 28, 2023
Merged

Add music/piano/keyboard/guitar/pick/amp/drum/album/audio/waveform icons #1124

merged 19 commits into from
Nov 28, 2023

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Apr 20, 2023 •
edited
Loading

For MIDI files, DAW files etc…

Alternatives considered:

preview

@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

Added or changed icons

icons/audio-lines.svg icons/audio-waveform.svg icons/disc-album.svg icons/drum.svg icons/file-music.svg icons/guitar.svg icons/keyboard-music.svg icons/piano.svg icons/speaker.svg

Preview cohesion icons/pi-square.svg icons/check-square-2.svg icons/split-square-horizontal.svg icons/menu-square.svg icons/sigma-square.svg icons/library-square.svg icons/split-square-vertical.svg icons/function-square.svg icons/square-user.svg
icons/audio-lines.svg icons/audio-waveform.svg icons/disc-album.svg icons/drum.svg icons/file-music.svg icons/guitar.svg icons/keyboard-music.svg icons/piano.svg icons/speaker.svg
icons/squirrel.svg icons/shapes.svg icons/key.svg icons/cylinder.svg icons/archive-restore.svg icons/recycle.svg icons/square-dot.svg icons/flip-vertical.svg icons/file-question.svg
Preview stroke widths icons/audio-lines.svg icons/audio-waveform.svg icons/disc-album.svg icons/drum.svg icons/file-music.svg icons/guitar.svg icons/keyboard-music.svg icons/piano.svg icons/speaker.svg
icons/audio-lines.svg icons/audio-waveform.svg icons/disc-album.svg icons/drum.svg icons/file-music.svg icons/guitar.svg icons/keyboard-music.svg icons/piano.svg icons/speaker.svg
icons/audio-lines.svg icons/audio-waveform.svg icons/disc-album.svg icons/drum.svg icons/file-music.svg icons/guitar.svg icons/keyboard-music.svg icons/piano.svg icons/speaker.svg
DPI Preview (24px) icons/audio-lines.svg icons/audio-waveform.svg icons/disc-album.svg icons/drum.svg icons/file-music.svg icons/guitar.svg icons/keyboard-music.svg icons/piano.svg icons/speaker.svg
Icon X-rays icons/audio-lines.svg icons/audio-waveform.svg icons/disc-album.svg icons/drum.svg icons/file-music.svg icons/guitar.svg icons/keyboard-music.svg icons/piano.svg icons/speaker.svg

@karsa-mistmere
Copy link
Member

All of these have guideline violations I'm afraid. :(

Also, sorry, but who gave you access to my drafts? I have almost the exact same icon there as part of a set. 😆
image

@danielbayley
Copy link
Member Author

Also, sorry, but who gave you access to my drafts? I have almost the exact same icon there as part of a set. 😆 image

Great minds think alike… 😉

All of these have guideline violations I'm afraid. :(

The black keys?

@karsa-mistmere
Copy link
Member

All of these have guideline violations I'm afraid. :(

The black keys?

Exactly.

@danielbayley
Copy link
Member Author

danielbayley commented Apr 21, 2023 •
edited
Loading

Love just the 3 keys version!

The black keys?

Exactly.

Doesn’t your piano use the same trick?

@karsa-mistmere
Copy link
Member

Yeah, which is part of the reason why I haven't posted it. :)

@ericfennis
Copy link
Member

I think we should make the keys simpel, like the piano of @karsa-mistmere.

@danielbayley
Copy link
Member Author

danielbayley commented Apr 23, 2023 •
edited
Loading

@karsa-mistmere @ericfennis Just pushed some nice options to choose from, see what you guys think…

Untitled

Maybe we should keep this PR for key[board]/piano, and a separate one for all your other brass/string instruments @karsa-mistmere?

@karsa-mistmere
Copy link
Member

All of the ones with the strong keys will have to be removed, I'm afraid.

Also not sure about the file icon, without the context of the piano shape it's just not very legible.

@jguddas
Copy link
Member

jguddas commented Apr 25, 2023

Not convince by any of them tbh.

@ericfennis
Copy link
Member

I think these icons need some more exploring. For now, to keep focus, I think only the current piano will fit this PR.
For the other icons MIDI, I think we can better discuss this in an issue or discussion.

@vercel
Copy link

vercel bot commented May 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lucide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 5:26pm
lucide-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 5:26pm

@vercel vercel bot temporarily deployed to Preview – lucide-docs May 1, 2023 01:36 Inactive
@vercel vercel bot temporarily deployed to Preview – lucide-docs May 1, 2023 01:43 Inactive
@danielbayley
Copy link
Member Author

All of the ones with the strong keys will have to be removed, I'm afraid.

@karsa-mistmere How come, are lines not allowed to join? I don’t see how the centred black notes are a violation…?

In any case, latest push is just the simplified notes variation. The matching file-music seems obvious enough to me (if part of the set). But can remove if insist…

@danielbayley danielbayley mentioned this pull request May 1, 2023
Open
ericfennis
ericfennis reviewed May 6, 2023
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file music is not very recognizable, for music, I think a music note is more obvious.
Maybe iterate on that one more as well.

@danielbayley
Copy link
Member Author

danielbayley commented May 6, 2023 •
edited
Loading

I think a music note is more obvious. Maybe iterate on that one more as well.

@ericfennis

Untitled

Untitled

@danielbayley danielbayley requested a review from jguddas August 1, 2023 18:11
@ericfennis
Copy link
Member

@danielbayley I vote for you second file-music file.
Can we have usecases for guitar-amp and guitar-pick it's not clear to me.

@ericfennis ericfennis merged commit 27c0a13 into lucide-icons:main Nov 28, 2023
3 checks passed
@danielbayley
Copy link
Member Author

Can we have usecases for guitar-amp and guitar-pick it's not clear to me.

@ericfennis guitar-pick same case as guitar really, but a nicer/more graphic/icon-like way to represent it, which might well fit better with other icons, depending on the situation…

@danielbayley danielbayley deleted the piano branch November 28, 2023 23:01
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
@danielbayley @ericfennis
Add music/piano/keyboard/guitar/pick/amp/drum/album/`au…
dedc2f1 
…dio`/waveform icons (lucide-icons#1124)

* Add `piano` icon

* Add `keyboard-music` icon

* Optimise `speaker` icon

* Refine `speaker` icon

* Improve metadata

* Add `guitar` icon

* Add `guitar-pick` icon

* Add `guitar-amp` icon

* Add `drum` icon

* Add `disc-album` icon

* Add `disc-album-remove` icon

* Add `disc-album` variant

* Add `file-music` icon

* Add `audio-waveform` icon

* Add `audio-lines` icon

* Refine `speaker` icon

* Remove icons

---------

Co-authored-by: Eric Fennis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis Awaiting requested review from ericfennis

@jguddas jguddas Awaiting requested review from jguddas

Assignees
No one assigned
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbayley @karsa-mistmere @ericfennis @jguddas