Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try fast bigDecimal parser via jackson-core (experiment) #2426

Draft
wants to merge 6 commits into
base: 6.2
Choose a base branch
from

Conversation

zspitzer
Copy link
Member

@zspitzer zspitzer commented Oct 31, 2024

Just wanted to try the fasterDouble Parser out as per https://luceeserver.atlassian.net/browse/LDEV-3524

https://github.com/wrandelshofer/FastDoubleParser

That lib doesn't include OSGI metadata, but jackson-core does, so I thought I'd try it out

Usual process for adding a new java library to Lucee

  • add to core and loader pom.xml files
  • add to the core MANIFEST.mf file
  • I also tried adding an entry to the osgi-maven-mapping.ini and the BundleProvider (but that's in the loader)

Then I imported the class into caster and swapped out the default method

Dropping the .lco into the deploy folder throws the following error

deploy.log ERROR 11:25:05, 31 Oct, 2024Thread-3222
"java.lang.NoSuchMethodException:No matching method for lucee.loader.engine.CFMLEngineFactory._restart() found. there are no methods with this name.;java.lang.NoSuchMethodException:No matching method for lucee.loader.engine.CFMLEngineFactory._restart() found. there are no methods with this name.;java.lang.NoSuchMethodException:No matching method for lucee.loader.engine.CFMLEngineFactory._restart() found. there are no methods with this name.;No matching method for lucee.loader.engine.CFMLEngineFactory._restart() found. there are no methods with this name.;lucee.runtime.exp.NativeException: java.lang.NoSuchMethodException:No matching method for lucee.loader.engine.CFMLEngineFactory._restart() found. there are no methods with this name.
at lucee.commons.lang.ExceptionUtil.toIOException(ExceptionUtil.java:215)
at lucee.commons.lang.ExceptionUtil.toIOException(ExceptionUtil.java:213)
at lucee.transformer.dynamic.meta.dynamic.MethodDynamic.invoke(MethodDynamic.java:27)
at lucee.runtime.config.ConfigAdmin.restart(ConfigAdmin.java:3870)
at lucee.runtime.config.ConfigAdmin.updateCore(ConfigAdmin.java:4547)
at lucee.runtime.config.DeployHandler.deploy(DeployHandler.java:101)
at lucee.runtime.engine.Controler.control(Controler.java:209)
at lucee.runtime.engine.Controler$ControlerThread.run(Controler.java:118)
Caused by: java.io.IOException: java.lang.NoSuchMethodException:No matching method for lucee.loader.engine.CFMLEngineFactory._restart() found. there are no methods with this name.
... 8 more
Caused by: java.lang.NoSuchMethodException: No matching method for lucee.loader.engine.CFMLEngineFactory._restart() found. there are no methods with this name.
at lucee.transformer.dynamic.meta.Clazz.getMethodMatch(Clazz.java:271)
at lucee.transformer.dynamic.DynamicInvoker.createInstance(DynamicInvoker.java:158)
at lucee.runtime.reflection.pairs.MethodInstance.getResult(MethodInstance.java:119)
at lucee.runtime.reflection.pairs.MethodInstance.invoke(MethodInstance.java:64)
at lucee.transformer.dynamic.meta.dynamic.MethodDynamic.invoke(MethodDynamic.java:24)
... 5 more
"
deploy.log INFO 11:25:05, 31 Oct, 2024Thread-3222
"Installing Lucee [6.2.0.144-SNAPSHOT] (previous version was [6.2.0.142-SNAPSHOT] )"

Which is probably due to Lucee not being able to dynamically download the new dependency, which I confirmed as stopping Tomcat and instead using the fat jar compiles off this branch, which works fine?

I was using the 6.0.3.1 loader, also tried the 6.2.0.142 loader, same problem.

Did I miss a step?

I think previously we got a better exception / more logging prior to the move to maven?

@zspitzer zspitzer marked this pull request as draft October 31, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant