try fast bigDecimal parser via jackson-core (experiment) #2426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to try the fasterDouble Parser out as per https://luceeserver.atlassian.net/browse/LDEV-3524
https://github.com/wrandelshofer/FastDoubleParser
That lib doesn't include OSGI metadata, but jackson-core does, so I thought I'd try it out
Usual process for adding a new java library to Lucee
pom.xml
filesMANIFEST.mf
fileosgi-maven-mapping.ini
and the BundleProvider (but that's in the loader)Then I imported the class into caster and swapped out the default method
Dropping the
.lco
into the deploy folder throws the following errorWhich is probably due to Lucee not being able to dynamically download the new dependency, which I confirmed as stopping Tomcat and instead using the fat jar compiles off this branch, which works fine?
I was using the 6.0.3.1 loader, also tried the 6.2.0.142 loader, same problem.
Did I miss a step?
I think previously we got a better exception / more logging prior to the move to maven?