Fix issue #101 #123
Closed
Fix issue #101 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @grandsir, sorry for my very late reply. I think #101 is a bug, not something we should keep as a feature that can be enabled. Or are there any side effect to disabling the animations on the drag indicator? Therefore I would happy to merge this pull request, if you update it! Also please include a Changelog mention. Greetings from Passau, |
lucaszischka
added a commit
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds a modifier called
enableAnimationsOnDragIndicator, which enables the animations on drag indicator, it is false by default, so that issue on 101 is fixed by default as well, only will occur if you addenableAnimationsOnDragIndicatorto the view, I added that because maybe someone will want to add some animations, more customization is better.the left phone is with enableAnimationsOnDragIndicator , and the right is without it.
Screen.Recording.2023-03-11.at.13.42.52.mp4